Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cred helper refactor for windows #612

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

vsiravar
Copy link
Contributor

@vsiravar vsiravar commented Oct 6, 2023

Issue #, if available:

Description of changes:

  • Refactor credhelper and remove hard-coded paths.
    Testing done:
    Yes, can push to ECR
 cat .\config.json
{"credsStore":"ecr-login"}

PS C:\Users\Administrator> finch build -t test-ecr-from-local .
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest^C
PS C:\Users\Administrator> finch push 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
INFO[0000] pushing as a reduced-platform image (application/vnd.docker.distribution.manifest.v2+json, sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051)
manifest-sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:1cad2846fc76fdde7217fb06db38fbcdccaed71baccc30a7e8ec70f095ea3d11:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.1 s                                                                    total:  1.1 Ki (1001.0 B/s)
  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean change, thanks!

@vsiravar vsiravar merged commit c6a4d9a into runfinch:windev Oct 6, 2023
vsiravar added a commit that referenced this pull request Oct 17, 2023
Issue #, if available:

*Description of changes:*
- Refactor credhelper and remove hard-coded paths. 
*Testing done:*
Yes, can push to ECR 

```
 cat .\config.json
{"credsStore":"ecr-login"}

PS C:\Users\Administrator> finch build -t test-ecr-from-local .
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest^C
PS C:\Users\Administrator> finch push 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
INFO[0000] pushing as a reduced-platform image (application/vnd.docker.distribution.manifest.v2+json, sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051)
manifest-sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:1cad2846fc76fdde7217fb06db38fbcdccaed71baccc30a7e8ec70f095ea3d11:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.1 s                                                                    total:  1.1 Ki (1001.0 B/s)
```


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
Co-authored-by: Vishwas Siravara <[email protected]>
vsiravar added a commit that referenced this pull request Oct 17, 2023
Issue #, if available:

*Description of changes:*
- Refactor credhelper and remove hard-coded paths.
*Testing done:*
Yes, can push to ECR

```
 cat .\config.json
{"credsStore":"ecr-login"}

PS C:\Users\Administrator> finch build -t test-ecr-from-local .
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
PS C:\Users\Administrator> finch tag test-ecr-from-local:latest 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest^C
PS C:\Users\Administrator> finch push 065363855432.dkr.ecr.us-east-2.amazonaws.com/test-ecr-from-local:latest
INFO[0000] pushing as a reduced-platform image (application/vnd.docker.distribution.manifest.v2+json, sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051)
manifest-sha256:317cda6f2c180388322d9134cf8976aac777a5d6cf1a56161ac22e996a1df051: done           |++++++++++++++++++++++++++++++++++++++|
config-sha256:1cad2846fc76fdde7217fb06db38fbcdccaed71baccc30a7e8ec70f095ea3d11:   done           |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.1 s                                                                    total:  1.1 Ki (1001.0 B/s)
```

- [X] I've reviewed the guidance in CONTRIBUTING.md

#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Vishwas Siravara <[email protected]>
Co-authored-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants