fix: unmarshal additional disks #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendo324
approved these changes
Oct 6, 2023
disks in the list format in lima override.yaml were not being
unmarshalled properly, causing a disk with the name "" to be mixed with
finch lima yaml, resulting in startup failure. This only occurs on inits
of a vm other than the very first init. init a vm the first time,
_output/lima/data/_config/override.yaml:
```yaml
additionalDisks:
- name: finch
```
stop and remove the vm, then re-init:
```yaml
additionalDisks:
- name: ""
- name: finch
```
to fix, copy upstream logic from lima to use a custom unmarshaler for
the Disk type.
Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
windev-cfg-disks
branch
from
042dfb4 to
2ed24da
Compare
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available:
*Description of changes:*
disks in the list format in lima override.yaml were not being
unmarshalled properly, causing a disk with the name "" to be mixed with
finch lima yaml, resulting in startup failure. This only occurs on inits
of a vm other than the very first init. init a vm the first time,
_output/lima/data/_config/override.yaml:
```yaml
additionalDisks:
- name: finch
```
stop and remove the vm, then re-init:
```yaml
additionalDisks:
- name: ""
- name: finch
```
to fix, copy upstream logic from lima to use a custom unmarshaler for
the Disk type.
*Testing done:*
`make test-unit`
manual testing
- [x] I've reviewed the guidance in CONTRIBUTING.md
#### License Acceptance
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: Gavin Inglis <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available:
*Description of changes:*
disks in the list format in lima override.yaml were not being
unmarshalled properly, causing a disk with the name "" to be mixed with
finch lima yaml, resulting in startup failure. This only occurs on inits
of a vm other than the very first init. init a vm the first time,
_output/lima/data/_config/override.yaml:
```yaml
additionalDisks:
- name: finch
```
stop and remove the vm, then re-init:
```yaml
additionalDisks:
- name: ""
- name: finch
```
to fix, copy upstream logic from lima to use a custom unmarshaler for
the Disk type.
*Testing done:*
`make test-unit`
manual testing
- [x] I've reviewed the guidance in CONTRIBUTING.md
#### License Acceptance
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Signed-off-by: Gavin Inglis <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
disks in the list format in lima override.yaml were not being unmarshalled properly, causing a disk with the name "" to be mixed with finch lima yaml, resulting in startup failure. This only occurs on inits of a vm other than the very first init. init a vm the first time, _output/lima/data/_config/override.yaml:
stop and remove the vm, then re-init:
to fix, copy upstream logic from lima to use a custom unmarshaler for the Disk type.
Testing done:
make test-unitmanual testing
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.