ci: Finch Windows MSI tool #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
pendo324
reviewed
Oct 12, 2023
| SET FilePath=%InstallDir%\os\finch.yaml | ||
|
|
||
| if exist "%FilePath%" ( | ||
| powershell -Command "$installPath = '%InstallDir%'.Replace('\', '/'); (Get-Content '%FilePath%') -replace '__INSTALLFOLDER__', $installPath | Set-Content '%FilePath%'" |
There was a problem hiding this comment.
I don't see where __INSTALLFOLDER__ is set. Should there be a manual step to add it to os\finch.yaml before starting to build the installer?
There was a problem hiding this comment.
It is set when build Finch: make FINCH_ROOTFS_LOCATION_ROOT=/INSTALLFOLDER, similar to mac OS: https://github.com/runfinch/finch/blob/e21ae836d4f73ea07852e3cd1fc6cc16d56e4f32/.github/workflows/build-and-test-pkg.yaml#L62C12-L62C12
I have the github action for auto build, so we don't need to do it manually, unless we want to build it at local env
There was a problem hiding this comment.
Thanks. We should probably still add that to the README just in case we ever need to do a manual build
There was a problem hiding this comment.
Thanks. I will update the ReadMe with the auto build PR.
pendo324
approved these changes
Oct 12, 2023
| SET FilePath=%InstallDir%\os\finch.yaml | ||
|
|
||
| if exist "%FilePath%" ( | ||
| powershell -Command "$installPath = '%InstallDir%'.Replace('\', '/'); (Get-Content '%FilePath%') -replace '__INSTALLFOLDER__', $installPath | Set-Content '%FilePath%'" |
There was a problem hiding this comment.
Thanks. We should probably still add that to the README just in case we ever need to do a manual build
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* MSI tool to generate Windows installer *Testing done:* Tested with github action and locally - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: [email protected] <[email protected]> Co-authored-by: [email protected] <[email protected]>
vsiravar
pushed a commit
that referenced
this pull request
Oct 17, 2023
Issue #, if available: *Description of changes:* MSI tool to generate Windows installer *Testing done:* Tested with github action and locally - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: [email protected] <[email protected]> Co-authored-by: [email protected] <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]>
1 task
pendo324
added a commit
that referenced
this pull request
Jan 10, 2024
Issue #, if available: *Description of changes:* - translation logic to wsl paths - persistent disk for windows - CI/CD (workflows to run CI on every PR on windows runners, MSI builder, Windows release automation) This PR combines 4 distinct PRs to a separate windev branch. - additional disk for windows #594 - translation logic for wsl paths #581 - CI #581 - Installer #624 This PR also contains bug fixes and modifications to e2e tests. *Testing done:* Yes - [X] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Vishwas Siravara <[email protected]> Signed-off-by: Vishwas Siravara <[email protected]> Signed-off-by: Gavin Inglis <[email protected]> Signed-off-by: Justin Alvarez <[email protected]> Signed-off-by: chaoningusc <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Kevin Li <[email protected]> Co-authored-by: Vishwas Siravara <[email protected]> Co-authored-by: Gavin Inglis <[email protected]> Co-authored-by: Justin <[email protected]> Co-authored-by: Kevin Li <[email protected]> Co-authored-by: chaoningusc <[email protected]> Co-authored-by: Justin Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
MSI tool to generate Windows installer
Testing done:
Tested with github action and locally
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.