Skip to content

Commit

Permalink
Add focus styles (Uniswap#375)
Browse files Browse the repository at this point in the history
* Add focus styles

* remove periods

* Change copy and button hover state
  • Loading branch information
callil authored and NoahZinsmeister committed Jul 29, 2019
1 parent 30887ef commit 66604cf
Show file tree
Hide file tree
Showing 6 changed files with 94 additions and 46 deletions.
4 changes: 2 additions & 2 deletions public/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"noLiquidity": "No liquidity.",
"insufficientLiquidity": "Insufficient liquidity.",
"unlockTokenCont": "Please unlock token to continue.",
"transactionDetails": "Transaction Details",
"transactionDetails": "Advanced Details",
"hideDetails": "Hide Details",
"slippageWarning": "Slippage Warning",
"highSlippageWarning": "High Slippage Warning",
Expand Down Expand Up @@ -81,5 +81,5 @@
"decimals": "Decimals",
"enterTokenCont": "Enter a token address to continue",
"priceChange": "Expected price slippage",
"forAtLeast" : "for at least "
"forAtLeast": "for at least "
}
4 changes: 2 additions & 2 deletions src/components/ContextualInfo/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ class ContextualInfo extends Component {
}

static defaultProps = {
openDetailsText: 'Transaction Details',
closeDetailsText: 'Hide Details',
openDetailsText: 'Advanced Details',
closeDetailsText: 'Hide Advanced',
renderTransactionDetails() {},
contextualInfo: '',
isError: false
Expand Down
4 changes: 2 additions & 2 deletions src/components/ContextualInfoNew/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ const ColoredDropdown = styled(WrappedDropdown)`
`

export default function ContextualInfo({
openDetailsText = 'Transaction Details',
closeDetailsText = 'Hide Details',
openDetailsText = 'Advanced Details',
closeDetailsText = 'Hide Advanced',
contextualInfo = '',
allowExpand = false,
isError = false,
Expand Down
3 changes: 2 additions & 1 deletion src/components/CurrencyInputPanel/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const SubCurrencySelect = styled.button`
outline: none;
cursor: pointer;
user-select: none;
`

const InputRow = styled.div`
Expand Down Expand Up @@ -70,7 +71,7 @@ const CurrencySelect = styled.button`
}
:focus {
box-shadow: 0 0 1px 1px ${({ theme }) => theme.malibuBlue};
border: 1px solid ${({ theme }) => darken(0.1, theme.royalBlue)};
}
:active {
Expand Down
119 changes: 83 additions & 36 deletions src/components/TransactionDetails/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { useState, useEffect, useRef } from 'react'
import { useTranslation } from 'react-i18next'
import styled, { css, keyframes } from 'styled-components'
import { transparentize, darken } from 'polished'
import { darken, lighten } from 'polished'
import { amountFormatter } from '../../utils'
import { useDebounce } from '../../hooks'

Expand Down Expand Up @@ -105,30 +105,58 @@ const FancyButton = styled.button`
min-width: 55px;
height: 2rem;
border-radius: 36px;
font-size: 12px;
border: 1px solid ${({ theme }) => theme.mercuryGray};
outline: none;
background: ${({ theme }) => theme.white};
:hover {
cursor: inherit;
border: 1px solid ${({ theme }) => theme.royalBlue};
box-shadow: ${({ theme }) => transparentize(0.6, theme.royalBlue)} 0px 0px 0px 2px;
border: 1px solid ${({ theme }) => theme.chaliceGray};
}
:focus {
box-shadow: ${({ theme }) => transparentize(0.6, theme.royalBlue)} 0px 0px 0px 2px;
border: 1px solid ${({ theme }) => theme.royalBlue};
/* box-shadow: 0 0 1px 1px #5CA2FF; */
}
`

const Option = styled(FancyButton)`
margin-right: 8px;
margin-top: 6px;
:hover {
cursor: pointer;
}
${({ active, theme }) =>
active &&
css`
background-color: ${({ theme }) => theme.royalBlue};
color: ${({ theme }) => theme.white};
border: none;
:hover {
border: none;
box-shadow: none;
background-color: ${({ theme }) => darken(0.05, theme.royalBlue)};
}
:focus {
border: none;
box-shadow: none;
background-color: ${({ theme }) => lighten(0.05, theme.royalBlue)};
}
:active {
background-color: ${({ theme }) => darken(0.05, theme.royalBlue)};
}
:hover:focus {
background-color: ${({ theme }) => theme.royalBlue};
}
:hover:focus:active {
background-color: ${({ theme }) => darken(0.05, theme.royalBlue)};
}
`}
`

Expand Down Expand Up @@ -198,6 +226,9 @@ const OptionCustom = styled(FancyButton)`
active &&
css`
border: 1px solid ${({ theme }) => theme.royalBlue};
:hover {
border: 1px solid ${({ theme }) => darken(0.1, theme.royalBlue)};
}
`}
${({ color }) =>
Expand All @@ -219,7 +250,7 @@ const Bold = styled.span`
`

const LastSummaryText = styled.div`
margin-top: 0.6rem;
padding-top: 0.5rem;
`

const SlippageSelector = styled.div`
Expand Down Expand Up @@ -252,6 +283,14 @@ const TransactionInfo = styled.div`
padding: 1.25rem 1.25rem 1rem 1.25rem;
`

const ValueWrapper = styled.span`
padding: 0.125rem 0.3rem 0.1rem 0.3rem;
background-color: ${({ theme }) => darken(0.04, theme.concreteGray)};
border-radius: 12px;
font-variant: tabular-nums;
vertical
`

export default function TransactionDetails(props) {
const { t } = useTranslation()

Expand Down Expand Up @@ -513,25 +552,29 @@ export default function TransactionDetails(props) {
<TransactionInfo>
<div>
{t('youAreSelling')}{' '}
{b(
`${amountFormatter(
props.independentValueParsed,
props.independentDecimals,
Math.min(4, props.independentDecimals)
)} ${props.inputSymbol}`
)}{' '}
{t('forAtLeast')}
{b(
`${amountFormatter(
props.dependentValueMinumum,
props.dependentDecimals,
Math.min(4, props.dependentDecimals)
)} ${props.outputSymbol}`
)}
<ValueWrapper>
{b(
`${amountFormatter(
props.independentValueParsed,
props.independentDecimals,
Math.min(4, props.independentDecimals)
)} ${props.inputSymbol}`
)}
</ValueWrapper>{' '}
{t('forAtLeast')}{' '}
<ValueWrapper>
{b(
`${amountFormatter(
props.dependentValueMinumum,
props.dependentDecimals,
Math.min(4, props.dependentDecimals)
)} ${props.outputSymbol}`
)}
</ValueWrapper>
.
</div>
<LastSummaryText>
{t('priceChange')} {b(`${props.percentSlippageFormatted}%`)}.
{t('priceChange')} <ValueWrapper>{b(`${props.percentSlippageFormatted}%`)}</ValueWrapper>
</LastSummaryText>
</TransactionInfo>
)
Expand All @@ -540,28 +583,32 @@ export default function TransactionDetails(props) {
<TransactionInfo>
<div>
{t('youAreBuying')}{' '}
{b(
`${amountFormatter(
props.independentValueParsed,
props.independentDecimals,
Math.min(4, props.independentDecimals)
)} ${props.outputSymbol}`
)}
<ValueWrapper>
{b(
`${amountFormatter(
props.independentValueParsed,
props.independentDecimals,
Math.min(4, props.independentDecimals)
)} ${props.outputSymbol}`
)}
</ValueWrapper>
.
</div>
<LastSummaryText>
{t('itWillCost')}{' '}
{b(
`${amountFormatter(
props.dependentValueMaximum,
props.dependentDecimals,
Math.min(4, props.dependentDecimals)
)} ${props.inputSymbol}`
)}{' '}
<ValueWrapper>
{b(
`${amountFormatter(
props.dependentValueMaximum,
props.dependentDecimals,
Math.min(4, props.dependentDecimals)
)} ${props.inputSymbol}`
)}
</ValueWrapper>{' '}
{t('orTransFail')}
</LastSummaryText>
<LastSummaryText>
{t('priceChange')} {b(`${props.percentSlippageFormatted}%`)}.
{t('priceChange')} <ValueWrapper>{b(`${props.percentSlippageFormatted}%`)}</ValueWrapper>
</LastSummaryText>
</TransactionInfo>
)
Expand Down
6 changes: 3 additions & 3 deletions src/theme/components.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled, { keyframes } from 'styled-components'
import { lighten, darken } from 'polished'
import { darken } from 'polished'

export const Button = styled.button.attrs(({ warning, theme }) => ({
backgroundColor: warning ? theme.salmonRed : theme.royalBlue
Expand All @@ -18,11 +18,11 @@ export const Button = styled.button.attrs(({ warning, theme }) => ({
:hover,
:focus {
background-color: ${({ backgroundColor }) => lighten(0.05, backgroundColor)};
background-color: ${({ backgroundColor }) => darken(0.05, backgroundColor)};
}
:active {
background-color: ${({ backgroundColor }) => darken(0.05, backgroundColor)};
background-color: ${({ backgroundColor }) => darken(0.1, backgroundColor)};
}
:disabled {
Expand Down

0 comments on commit 66604cf

Please sign in to comment.