Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore thirdparty and advertizing cookies (set by Slack on browser login) #158

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

rusq
Copy link
Owner

@rusq rusq commented Oct 16, 2022

While investigating some other issue, and using EZ-Login 3000 with "email login" feature, i started getting strange errors that I've never seen before:

2022/10/16 21:21:47 net/http: invalid byte '"' in Cookie.Value; dropping invalid bytes

This did not happen when user/password login type was used.

Observing browser behaviour, stepping through debugger, and examining the cookies revealed the following: after successful workspace login with email method (slack sends an email with the code to enter on the login page), slack opens another tab of the [puppet] browser, which quickly sets all advertizing and tracking cookies.

Some facts:

  • Total amount of cookies set by slack: 84; out of which
    • Cookies with "slack.com" domain and variations: 26
    • Tracking and advertising cookies: 58 (!)

The solution is - to cut them off after we grab the cookies from [puppet] browser.

@rusq rusq merged commit a89595a into master Oct 16, 2022
@rusq rusq deleted the no-3rdp-cookies branch October 16, 2022 11:40
@rusq rusq changed the title Ignore thirdparty cookies (set by Slack on browser login) Ignore thirdparty and advertizing cookies (set by Slack on browser login) Oct 16, 2022
@rusq rusq added this to the v2.2.3 milestone Oct 16, 2022
rusq added a commit that referenced this pull request Nov 29, 2022
rusq added a commit that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant