Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the standard Input impl to support any slice #1810

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcdejonge
Copy link
Contributor

The main change is that the Item is a reference instead of a copy.

It also adds an IntoInput type that makes it easier to deal with inputs for the tag and take functions.

Possible solution to solve #1809 and #1799

The main change is that the Item is a reference instead of a copy
@marcdejonge marcdejonge force-pushed the generic-input-implementation branch from 6369ccb to 69c0d5b Compare February 10, 2025 13:18
Copy link

codspeed-hq bot commented Feb 10, 2025

CodSpeed Performance Report

Merging #1810 will improve performances by 35.77%

Comparing marcdejonge:generic-input-implementation (765bfa8) with main (a44b52e)

Summary

⚡ 2 improvements
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
float bytes 1.9 µs 1.7 µs +10.99%
float bytes streaming 748.6 ns 551.4 ns +35.77%

@marcdejonge marcdejonge marked this pull request as ready for review February 10, 2025 16:52
@marcdejonge marcdejonge requested a review from Geal as a code owner February 10, 2025 16:52
@marcdejonge
Copy link
Contributor Author

Probably also something for 9.0 if you even want to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant