-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration when cross-compiling #329
Conversation
Thanks John! Could you provide some documentation and/or comments alongside as you did on twitter in the code? Also it seems like formatting is off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a cargo fmt
away, simples ;)
The change is described in the commit message; beyond that, I don't know what documentation you're after. I am not a rust developer and I am unfamiliar with your expected formatting. Moreover, I am not a rust-htslib user and I am not keen to devote further time to this. I would suggest that the maintainers are best placed to make any adjustments required should they choose to merge this bug fix. |
Comment added, assuming what you were after was a comment in the source itself to further dissuade anyone naively reverting this to |
Pull Request Test Coverage Report for Build 1032302039
💛 - Coveralls |
…uild.rs runs on the build host. Hence within build.rs `#[cfg(target_os)]` always reflects the host, not the target. Use $CARGO_CFG_TARGET_OS instead to query target properties.
CI seemed to be stuck picking old commit messages, even with correctly formatted with Anyway, thanks John for the contribution. |
Even when cross-compiling, build.rs runs on the build host. Hence within build.rs
#[cfg(target_os)]
always reflects the host, not the target. Use$CARGO_CFG_TARGET_OS
instead to query target properties.Fixes #259.