-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update htslib & fix build.rs #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via a fork in FiloSottile/homebrew-musl-cross#13 (comment), so now it's fast to install (just a bottle pour) :)
…e clippy happy by removing 'use cc' entirely
Pull Request Test Coverage Report for Build 1038756060
💛 - Coveralls |
Thanks @pmarks ! |
brainstorm
added a commit
that referenced
this pull request
Jul 17, 2021
* This PR only bumps curl and libz-sys, the rest of the build.rs fixes discussed are addressed on PR #332 Co-authored-by: Patrick Marks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brainstorm this fixes
build.rs
on top of #237. Fix works on Mac, let's see what happens on other platforms. This at least keeps us going with the current style of build.rs