Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update htslib & fix build.rs #332

Merged
merged 11 commits into from
Jul 17, 2021
Merged

build: update htslib & fix build.rs #332

merged 11 commits into from
Jul 17, 2021

Conversation

pmarks
Copy link
Contributor

@pmarks pmarks commented Jul 16, 2021

@brainstorm this fixes build.rs on top of #237. Fix works on Mac, let's see what happens on other platforms. This at least keeps us going with the current style of build.rs

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1038756060

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 93.535%

Files with Coverage Reduction New Missed Lines %
src/bam/record.rs 1 74.21%
Totals Coverage Status
Change from base Build 1032305619: -0.008%
Covered Lines: 11502
Relevant Lines: 12297

💛 - Coveralls

@pmarks pmarks changed the title Zlib ng fix build: update htslib & fix build.rs Jul 16, 2021
@brainstorm brainstorm merged commit b1fc171 into master Jul 17, 2021
@brainstorm brainstorm deleted the zlib-ng-fix branch July 17, 2021 05:46
@brainstorm
Copy link
Member

Thanks @pmarks !

brainstorm added a commit that referenced this pull request Jul 17, 2021
* This PR only bumps curl and libz-sys, the rest of the build.rs fixes discussed are addressed on PR #332

Co-authored-by: Patrick Marks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants