Use range dependencies #158
Conversation
tcharding
force-pushed
the
04-10-range-deps
branch
from
94470b6 to
2ff068f
Compare
|
Hey @RCasatta, the changelog entry for the |
|
utACK 2ff068f
Yes please, and sorry that I forgot.
As you prefer |
During the last two releases we forgot to add a changelog.
The last couple of releases of `bitcoincore-rpc` and `bitcoin_hashes` have not required code changes here. This means we can use range dependencies. The benefit is that it makes the upgrade of other crates that use `bitcoind` easier. Tested by pinning `hashes` with: - cargo update -p [email protected] --precise 0.13.0 - cargo update -p [email protected] --precise 0.14.0 And then pinning `bitcoincore-rpc` with all of the dependencies in the range and running `cargo check --all --all-features --all-targets` E.g (using `cc` as alias to the cargo check command above) - cargo update -p bitcoincore-rpc --precise 0.17.0 && cc - cargo update -p bitcoincore-rpc --precise 0.18.0 && cc - cargo update -p bitcoincore-rpc --precise 0.19.0 && cc Bump the crate patch version so we can release this change in a point release. Since this is a pre-1.0 crate I believe this is ok to do.
In preparation for release bump the minor version number.
tcharding
force-pushed
the
04-10-range-deps
branch
from
2ff068f to
7694749
Compare
|
Done! I put a separate patch up the front for the missing changelog entries, this PR as a patch, and then a final "bump version number" patch for you to tag and release please. Also the tag for |
| @@ -11,7 +11,7 @@ edition = "2018" | |||
| categories = ["cryptography::cryptocurrencies", "development-tools::testing"] | |||
|
|
|||
| [dependencies] | |||
| bitcoincore-rpc = { version = "0.18.0" } | |||
| bitcoincore-rpc = { version = ">= 0.17.0, <= 0.19" } | |||
There was a problem hiding this comment.
Note, some nuance around the version number 0.19.0:
- that version does not exist (but cargo is ok with non-existent value in the range)
- that version has been created locally so we have some confidence that it will exist and will not break the build
- we don't use some random high number because we don't want to break
bitcoindby an unrelated later release ofbitcoincore-rpc - we have to do a point release bumping the top of the range every time we have an upcoming
bitcoincore-rpcrelease (implies everytimerust-bitcoinis releaseing)
|
utACK 7694749 |
|
Can we get this in please @RCasatta? |
|
utACK 7694749 Sorry for taking so long, I forgot going to release |
|
No sweat, thanks man! |
The last couple of releases of
bitcoincore-rpcandbitcoin_hasheshave not required code changes here. This means we can use range dependencies. The benefit is that it makes the upgrade of other crates that usebitcoindeasier.Tested by pinning
hasheswith:And then pinning
bitcoincore-rpcwith all of the dependencies in the range and runningcargo check --all --all-features --all-targetsE.g (using
ccas alias to the cargo check command above)Bump the crate patch version so we can release this change in a point release. Since this is a pre-1.0 crate I believe this is ok to do.