Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] unused-function warnings are not silenced #434

Open
junderw opened this issue Apr 1, 2022 · 1 comment
Open

[wasm] unused-function warnings are not silenced #434

junderw opened this issue Apr 1, 2022 · 1 comment

Comments

@junderw
Copy link
Contributor

junderw commented Apr 1, 2022

See: https://github.com/rust-bitcoin/rust-secp256k1/runs/5791848743?check_suite_focus=true#step:5:589

When compiling with WASM, for some reason -Wno-unused-function is ignored (not supported???)
tcharding added a commit to tcharding/rust-secp256k1 that referenced this issue Oct 31, 2023
@tcharding
Use flag when building secp sys
d476fc9 
We currently use the `cc::Build::flag_if_supported` function to pass in
`-Wno-unused-function` however when building for wasm the flag is
ignored.

Using plain old `flag` seems to work, found by trial and error, I did no
further investigation as to why it works and the other does not.

Resolves: rust-bitcoin#434
@tcharding tcharding mentioned this issue Oct 31, 2023
Closed
@tcharding
Copy link
Member

I've filed a bug on cc: rust-lang/cc-rs#892

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve WASM build tcharding/rust-secp256k1
2 participants
@junderw @tcharding