Let bors cut body after <details> #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
force-pushed
the
bors-cut-body-after-details
branch
from
4922ef1 to
fab801b
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 9, 2022
74: Let bors cut body after <details> r=matthiasbeyer a=matthiasbeyer This was set to "---" because I thought it would make life easier for contributors to use the markdown line "---". It turned out, though, that dependabot uses a ` Co-authored-by: Matthias Beyer <[email protected]>
|
Build failed: |
|
Running into #70 here I guess |
|
This bug is super annoying. I don't know what to do to reproduce it. I tried to run it directly on my machine, inside an Ubuntu 20.04 VM, as well as trying to run it inside an Ubuntu 20.04 container, looping 1000x each, and it never reproduced for me. |
This was set to "---" because I thought it would make life easier for contributors to use the markdown line "---". It turned out, though, that dependabot uses a "<details>" tag and puts a lot of HTML in there. We really don't want that in our merge messages. So this patch changes bors configuration to cut the merge message after the "<details>" tag. Signed-off-by: Matthias Beyer <[email protected]>
matthiasbeyer
force-pushed
the
bors-cut-body-after-details
branch
from
fab801b to
5a2451f
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was set to "---" because I thought it would make life easier for contributors to use the markdown line "---".
It turned out, though, that dependabot uses a
<details>tag and puts a lot of HTML in there. We really don't want that in our merge messages.So this patch changes bors configuration to cut the merge message after the
<details>tag.