Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a stable hash algorithm for checksums #62

Closed
aloucks opened this issue Feb 17, 2020 · 1 comment · Fixed by #63
Closed

Use a stable hash algorithm for checksums #62

aloucks opened this issue Feb 17, 2020 · 1 comment · Fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aloucks
Copy link
Contributor

aloucks commented Feb 17, 2020

The DefaultHasher intentionally omits details of what algorithm is used:

The internal algorithm is not specified, and so it and its hashes should not be relied upon over releases.

sha1 is probably a better choice.
@jxs
Copy link
Member

jxs commented Feb 18, 2020

Hi, nice catch thanks!
yeah we should def use a stable hasher, thing is Rust core seems to be using SipHasher13 so, to avoid breaking changes I would rather use rust-siphash which seems to be using the same implementation as rust core. Want to give it a go?

@jxs jxs added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2020
aloucks added a commit to aloucks/refinery that referenced this issue Feb 18, 2020
@aloucks
Use SipHasher13 instead of DefaultHasher
446d7ba 
Fixes rust-db#62
@aloucks aloucks mentioned this issue Feb 18, 2020
Merged
@jxs jxs closed this as completed in #63 Feb 20, 2020
jxs pushed a commit that referenced this issue Feb 20, 2020
@aloucks
Use SipHasher13 instead of DefaultHasher (#63)
f5806af 
* Use SipHasher13 instead of DefaultHasher

Fixes #62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use SipHasher13 instead of DefaultHasher aloucks/refinery
2 participants
@aloucks @jxs