Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_env_var #103

Merged
merged 1 commit into from
May 27, 2020
Merged

Add from_env_var #103

merged 1 commit into from
May 27, 2020

Conversation

c410-f3r
Copy link
Contributor

No description provided.

@c410-f3r c410-f3r mentioned this pull request May 26, 2020
Closed
jxs
jxs requested changes May 26, 2020
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a great start! 👍 left just 3 minor situations to be addressed

refinery_core/Cargo.toml Outdated Show resolved Hide resolved
refinery_core/src/config.rs Outdated Show resolved Hide resolved
refinery_core/src/config.rs Show resolved Hide resolved
@jxs jxs merged commit 947dd26 into rust-db:master May 27, 2020
@jxs
Copy link
Member

jxs commented May 27, 2020

thanks for adding it to refinery-cli too! windows tests are flaky but don't worry i'll see what i can do to fix them later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c410-f3r @jxs