Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unversioned Type #128

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

Krakaw
Copy link
Contributor

@Krakaw Krakaw commented Sep 19, 2020

This PR adds an "Unversioned" file type. These files are prefixed with U and ignore the order that the migrations get run. As long as the version does not conflict with another migration it doesn't matter what the order is of these files.

@Krakaw Krakaw force-pushed the feat-add-unversioned-types branch 8 times, most recently from 88d371a to 9e99721 Compare September 19, 2020 17:23
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks a lot for this! Only a minor issue described below

README.md Show resolved Hide resolved
Clean up boolean logic

cargo fmt for 1.22.1

Better boolean logic

Update migration loader regex

Fixed the version displays and file loading

Fix tests

fmt

Update README

Rename test

Update README.md with explanation
@Krakaw Krakaw force-pushed the feat-add-unversioned-types branch from 9e99721 to 6790b24 Compare September 22, 2020 02:54
rust-roolchain Outdated
@@ -0,0 +1 @@
1.22.1
Copy link
Member

@jxs jxs Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, the cargo fmt check was using that version, so I put it in.

@jxs jxs merged commit f6b90af into rust-db:master Sep 22, 2020
@jxs
Copy link
Member

jxs commented Sep 22, 2020

thanks! 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants