-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mysql and disabled default features #202
Conversation
- Bumped mysql to v22.0.0 - Disabled default features on mysql - Added flate2 crate with zlib feature, This previously came in via the mysql crate but now it no longer is, so it must be specified by us
Hi, and thanks for your interest! This seems legit, but can we make it so that |
…feature is enabled
Good point to also allow |
yeah, sorry for the spam fixing the typos also. |
Changes
Reasoning
MySQL default ships with
native-tls
, i.e. OpenSSL enabled by default. My PR to themysql
crate makes this optional but keeps OpenSSL enabled by default. However, when usingrefinery
it is still pulled in, even if it is not enabled in my binary crate due to the way Cargo resolves features.This PR makes
mysql
features optional, allowing the end user to choose if they wantnative-tls
, orrustls
e.g. By defaultmysql
also came with the featureflate2/zlib
, with disabled default featuresflate2/zlib
is no longer included. When usingrefinery
with only themysql
feature enabled it compiles fine. However, with the default feature set it no longer does (cargo b
fails with too many errors to count).Backwards compatibility
Backwards compatibility is maintained as the
OpenSSL
feature is still enabled by default via themysql
crate.Thanks