Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deserialize_any #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liarokapisv
Copy link

@liarokapisv liarokapisv commented Jan 12, 2025

This PR adds support for deserialize_any which is useful when trying to work around the lack of untagged enum support.

Mostly follows serde-json 's approach without the inlining.

There is definitely room for improvement when it comes to the implementation:

  • We can inline the delegated methods and avoid redundant checks
  • We can probably avoid the multiple delegations to from_str implementations when parsing for numbers.

This will probably require some cleanup, it currently uses a Visitor adaptor to take advantage of the existing deserialize_fromstr macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant