-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #134
Documentation updates #134
Conversation
22204d2
to
808b1a4
Compare
I've force-pushed changes to bump the patch version. Also can report that the tests pass on ATSAMD21 and ATSAMD51 boards when using a branch of the HAL that has a couple minor updates to work with the newer usb-device. Once the HAL changes are merged, I'll aim to get back to #100 |
Hello, can we use this opportunity to make BuilderError public or does it need it's own PR? |
Sounds good to me! @ithinuel does the new commit work for your purpose? |
Also adds documentation strings to BuilderError
It does, thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I'll release here when I get in the office :) thanks for the updates!
Sorry to throw this in at the last minute (and end of a long day for me - apologies if this doesn't make sense!) but I'm wondering if |
If people don't like the name, they can rename it during import. The same argument can be made for |
If #133 is accepted, this should have the explicit
use
forLangID
removed from the example code.