Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic contributor's page based on git commit history #124

Closed
wants to merge 1 commit into from
Closed

Add basic contributor's page based on git commit history #124

wants to merge 1 commit into from

Conversation

Nicoretti
Copy link
Contributor

  • Add inital contributor's page
  • Add script to generate conributors page

Related Issues:

@Nicoretti Nicoretti requested a review from a team as a code owner February 6, 2019 19:53
@Nicoretti
Copy link
Contributor Author

@jamesmunns I've seen the #123 you created, this PR might be a first start to address this issue. The script contributors.sh could be extended and hooked up with the ci.

greez
Nico

@therealprof
Copy link
Contributor

Hm, there're some duplicates in the contributors list. Also some people might prefer to be mentioned by their nick instead of their specified real name. We might have to do some postprocessing here, otherwise looks good to me.

@Nicoretti
Copy link
Contributor Author

Nicoretti commented Feb 7, 2019

@therealprof sure, thing. It was anyway intended to be some sort of a draft, to discuss up on. I could think of adding mappings for the nicknames. However if the handling shall be more complex, I would prefer to do it in python.

@therealprof
Copy link
Contributor

Using Python should be fine.

* Add inital contributor's page
* Add script to generate conributors page

Related Issues:
* #123
@jamesmunns
Copy link
Member

jamesmunns commented Feb 13, 2019

Hey @Nicoretti, thank you for the contribution! I'll do a quick vote of @rust-embedded/resources to see if we want to recognize people in this way.

If so, we can figure out some of the details around duplication, automation, etc.

@jamesmunns
Copy link
Member

CC @japaric - this would be another place where "bors runs some kind of script on every merge to master" would be useful.

@Disasm Disasm added the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label Feb 26, 2019
@adamgreig
Copy link
Member

Given the issues around duplication, people potentially not wanting their email address linked to, and not being able to have bors run a script yet, I think my vote would be to not have the Python script in the repo, but to run it once to generate a list of names, and then manually maintain the list and suggest new contributors add themselves to it if they want to when they submit PRs.

I'd probably have either a list of names or names linked to GitHub profiles, rather than email addresses.

@Nicoretti Nicoretti closed this Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants