Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs. #18

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Improve docs. #18

merged 3 commits into from
Aug 11, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Aug 10, 2022

No description provided.

@Dirbaio Dirbaio requested a review from a team as a code owner August 10, 2022 17:08
@Dirbaio Dirbaio mentioned this pull request Aug 10, 2022
README.md Outdated Show resolved Hide resolved
@eldruin eldruin added this to the v1.0.0 milestone Aug 11, 2022
This might seem it does nothing because there's no actual tests,
but it does test the rustdoc snippts.
@Dirbaio
Copy link
Member Author

Dirbaio commented Aug 11, 2022

Okay, I believe this is ready to go. @eldruin @therealprof @ryankurte could you please take a look? :D

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just saw a typo, thanks!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Build succeeded:

@bors bors bot merged commit 9b83f7e into main Aug 11, 2022
@bors bors bot deleted the improve-docs branch August 11, 2022 13:39
bors bot added a commit that referenced this pull request Aug 11, 2022
19: v1.0.0 release r=eldruin a=Dirbaio

Depends on #18 

Co-authored-by: Dario Nieuwenhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants