-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch async code to use futures crate #171
Conversation
r? @thejpster (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, but it's a significant change so we should probably RFC it, or at least discuss it in the meeting.
We shall need to fix the build failures.
Is there a reason this is using futures 0.1 instead of 0.3? |
@thejpster I fixed build on last commit. It is clean compatible changes with older code - only remove |
Interesting, I had no idea |
As per 11-26 meeting this will require an RFC to move ahead. |
|
@therealprof I added RFC on head message of this thread. |
@Nemo157 I understand that problem we have but in current implementation of |
Need to review of architecture solution. |
Remove using
nb
crate for asynchronously run code - usecore::futures
for replace it.RFC for these changes is #172