Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.rust-version does not match MSRV #43

Closed
Beanow opened this issue Oct 20, 2023 · 2 comments · Fixed by #44
Closed

package.rust-version does not match MSRV #43

Beanow opened this issue Oct 20, 2023 · 2 comments · Fixed by #44

Comments

@Beanow
Copy link
Contributor

Beanow commented Oct 20, 2023

#42 bumped the MSRV but forgot the Cargo file.

nb/Cargo.toml

Line 14 in 62c17d3

rust-version = "1.60"

@eldruin
Copy link
Member

eldruin commented Oct 26, 2023

Nice catch, could you submit a PR updating it?

Beanow added a commit to Beanow/nb that referenced this issue Oct 26, 2023
@Beanow
fix: Update MSRV in Cargo.toml
74606d1 
Closes rust-embedded#43

The MSRV was bumped in rust-embedded#42 but missed the `package.rust-version` metadata.
@Beanow Beanow mentioned this issue Oct 26, 2023
Merged
@Beanow
Copy link
Contributor Author

Beanow commented Oct 26, 2023

Sure, made one now

eldruin pushed a commit that referenced this issue Oct 27, 2023
@Beanow @eldruin
fix: Update MSRV in Cargo.toml
2fe7f68 
Closes #43

The MSRV was bumped in #42 but missed the `package.rust-version` metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update MSRV in Cargo.toml Beanow/nb
2 participants
@eldruin @Beanow