Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arbitrary v1.2.0 + derive doesn't build with generate-lockfile -Z minimal-versions #134

Closed
tarcieri opened this issue Dec 19, 2022 · 2 comments · Fixed by #135
Closed

arbitrary v1.2.0 + derive doesn't build with generate-lockfile -Z minimal-versions #134

tarcieri opened this issue Dec 19, 2022 · 2 comments · Fixed by #135

Comments

@tarcieri
Copy link
Contributor

It pulls in derive_arbitrary v1.1.6 which has the following build failure:

error[E0599]: no method named `len` found for reference `&Fields` in the current scope
   --> /home/runner/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/derive_arbitrary-1.1.6/src/lib.rs:219:30
    |
219 |         if idx + 1 == fields.len() {
    |                              ^^^ method not found in `&Fields`

Perhaps you could bump the derive_arbitrary requirement in arbitrary to 1.2.0 (it's presently 1.1.6) or yank the affected derive_arbitrary v1.1.6 release?

@fitzgen
Copy link
Member

fitzgen commented Jan 3, 2023

@Manishearth FWIW, this kind of thing is the reason why I try to always keep the versions in lock step with each other.

@Manishearth
Copy link
Member

Yeah, fair, I still think it should be fine for patches.

fitzgen added a commit to fitzgen/rust_arbitrary that referenced this issue Jan 3, 2023
tarcieri added a commit to RustCrypto/formats that referenced this issue Jan 3, 2023
…til rust-fuzz/arbitrary#134 is fixed"

This reverts commit 517adb7.

The issue in `arbitrary` has been fixed.
tarcieri added a commit to RustCrypto/formats that referenced this issue Jan 3, 2023
…til rust-fuzz/arbitrary#134 is fixed"

This reverts commit 517adb7.

The issue in `arbitrary` has been fixed.
baloo added a commit to baloo/formats that referenced this issue Mar 30, 2023
baloo added a commit to baloo/formats that referenced this issue Mar 30, 2023
baloo added a commit to baloo/formats that referenced this issue Mar 30, 2023
tarcieri pushed a commit to RustCrypto/formats that referenced this issue Mar 31, 2023
…til rust-fuzz/arbitrary#134 is fixed" (#961)

This reverts commit 517adb7.

The issue in `arbitrary` has been fixed: rust-fuzz/arbitrary#136

See #837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants