Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rusty roguelike macroquad #119

Merged
merged 4 commits into from
Aug 7, 2022

Conversation

ollej
Copy link
Contributor

@ollej ollej commented Jul 31, 2022

An implementation in Macroquad of the Rusty Roguelike from the book Hands-on Rust by Herbert Wolverson.

@64kramsystem
Copy link
Collaborator

Yikes. That was fast 😅.

It's going to take some time to review; sorry for this, but these are reference projects, and this project is also in its infancy, so I need to set the standars, put it on my schedule etc. 😄

I leave no PR unturned, though 😄 I'll ping you on the next week.

@64kramsystem 64kramsystem self-requested a review July 31, 2022 13:54
@erlend-sh
Copy link
Member

The author of Macroquad @not-fl3 might also have ideas for best practices in this example.

@64kramsystem
Copy link
Collaborator

The author of Macroquad @not-fl3 might also have ideas for best practices in this example.

That's a very good idea. What do you think of adding the engine maintainers as collaborators with read permissions, so that they could be requested to review (assuming I understand the collator permissions correctly), if they agree?

@ollej
Copy link
Contributor Author

ollej commented Jul 31, 2022

Yeah, I’m pretty sure it’s not up to par for best practices in neither Macroquad nor Rust. It might need some work to be a good example.

@64kramsystem
Copy link
Collaborator

Yeah, I’m pretty sure it’s not up to par for best practices in neither Macroquad nor Rust. It might need some work to be a good example.

Interesting, this is actually the project with Bracket-lib replaced by Macroquad (I thought the ECS part was ripped out, but it's been kept, which is ok, of course).

I'm in the process of updating the rust-game-ports project for general release, and discuss the port design priciples etc. (see starter here). I'll ping back once the discussions are done 😄

@64kramsystem
Copy link
Collaborator

I've had a first look and I think it looks good. The good side of immediate mode libraries is that there's really nothing to design, so it's hard to get it fundamentally wrong 😂

We're in the process of defining the acceptance guidelines, most importantly, the high level ones (I'm done with the low level ones, which I think are reasonable). After they're set, I/we are going to have a better look, then we'll follow up 😄

Copy link
Collaborator

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution ☺️

I've solved the conflicts; will merge shortly.

@64kramsystem 64kramsystem merged commit cb850d1 into rust-gamedev:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants