Skip to content

Commit

Permalink
put call to stacked borrows end_call in a more sensible place
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung committed Jul 2, 2022
1 parent c9925ff commit d9c441c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
5 changes: 4 additions & 1 deletion src/machine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,10 @@ impl<'mir, 'tcx> Machine<'mir, 'tcx> for Evaluator<'mir, 'tcx> {
unwinding: bool,
) -> InterpResult<'tcx, StackPopJump> {
let timing = frame.extra.timing.take();
let res = ecx.handle_stack_pop(frame.extra, unwinding);
if let Some(stacked_borrows) = &ecx.machine.stacked_borrows {
stacked_borrows.borrow_mut().end_call(frame.extra.call_id);
}
let res = ecx.handle_stack_pop_unwind(frame.extra, unwinding);
if let Some(profiler) = ecx.machine.profiler.as_ref() {
profiler.finish_recording_interval_event(timing.unwrap());
}
Expand Down
8 changes: 2 additions & 6 deletions src/shims/panic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,13 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
Ok(())
}

fn handle_stack_pop(
fn handle_stack_pop_unwind(
&mut self,
mut extra: FrameData<'tcx>,
unwinding: bool,
) -> InterpResult<'tcx, StackPopJump> {
let this = self.eval_context_mut();

trace!("handle_stack_pop(extra = {:?}, unwinding = {})", extra, unwinding);
if let Some(stacked_borrows) = &this.machine.stacked_borrows {
stacked_borrows.borrow_mut().end_call(extra.call_id);
}
trace!("handle_stack_pop_unwind(extra = {:?}, unwinding = {})", extra, unwinding);

// We only care about `catch_panic` if we're unwinding - if we're doing a normal
// return, then we don't need to do anything special.
Expand Down

0 comments on commit d9c441c

Please sign in to comment.