forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of rust-lang#134668 - compiler-errors:default-struct-value-fmt, r=ytmimi Make sure we don't lose default struct value when formatting struct The reason why rust-lang/rustfmt#6424 broke when rust-lang#129514 landed is because the parser now *successfully* parses default struct values. That means that where we used to fail in `rewrite_macro_inner`: https://github.com/rust-lang/rust/blob/e108481f74ff123ad98a63bd107a18d13035b275/src/tools/rustfmt/src/macros.rs#L263-L267 ... we now succeed, and we now proceed to format the inner struct as a macro arg. Since formatting was never implemented for default struct values, this means that we’ll always rewrite the struct to exclude the default value. This PR makes it so that we simply don’t rewrite struct fields if they have a default value. r? `@ytmimi`
- Loading branch information
Showing
4 changed files
with
42 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#![feature(default_struct_values)] | ||
|
||
// Test for now that nightly default field values are left alone for now. | ||
|
||
struct Foo { | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
|
||
struct Foo2 { | ||
#[rustfmt::skip] | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
|
||
a_macro!( | ||
struct Foo2 { | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#![feature(default_struct_values)] | ||
|
||
// Test for now that nightly default field values are left alone for now. | ||
|
||
struct Foo { | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
|
||
struct Foo2 { | ||
#[rustfmt::skip] | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
|
||
a_macro!( | ||
struct Foo2 { | ||
default_field: Spacing = /* uwu */ 0, | ||
} | ||
); |