Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

turn off newer RELX relocation optimizations #110

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

m4b
Copy link
Contributor

@m4b m4b commented Aug 1, 2016

otherwise breaks the link step on systems with an older linker (i.e., travis CI, some ubuntu's, etc.). ref rust-lang/rust#34978

We may only want to add this flag on nightly? Not sure how to do that...

NB requires a newer assembler (don't know exact minimal working version), but

as -version
GNU assembler (GNU Binutils) 2.26.0.20160501

works.

otherwise breaks the link step on systems with an older linker (i.e., travis CI, some ubuntu's, etc.). ref rust-lang/rust/#34978

We may only want to add this flag on nightly? Not sure how to do that...

*NB* requires a newer assembler (don't know exact minimal working version), but
```
as -version
GNU assembler (GNU Binutils) 2.26.0.20160501
```
works.
@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Contributor

Thanks! We shouldn't have to worry about the assembler version here as we're in control of it, but I think we'll also need to pass this to the build system, right? I remember the error being with jemalloc as well I think...

@alexcrichton alexcrichton merged commit 1e815c6 into rust-lang-deprecated:master Aug 1, 2016
@alexcrichton
Copy link
Contributor

Ok, I've pushed this as alexcrichton/rust-slave-linux:2016-08-01, it should go out the next time we restart the buildbots. Do you want to send a patch to set this for the musl target as well?

@m4b
Copy link
Contributor Author

m4b commented Aug 2, 2016

@alexcrichton I thought this was the musl target?

and yea, will need to pass to the build system, as the relocs show up in libstd and liballoc_jemalloc, as well as libunwind (but I hope it's cmake will obey the CFLAGS var?).

Unfortunately I'm not familiar with that part of building rust, and don't know if we have an equivalent CFLAGS somewhere in the pipeline?

@alexcrichton
Copy link
Contributor

Yeah it should be easy enough to modify the mk/cfg/*.mk files and also just add custom flags in src/bootstrap for the rustbuild build system. Also yeah this should only affect musl, and I think in the build system we only need to really worry about jemalloc, other pieces are fine to ignore I think.

@m4b m4b deleted the patch-2 branch August 2, 2016 05:00
@alexcrichton
Copy link
Contributor

Ok, new image is now deployed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants