Skip to content
This repository has been archived by the owner on Jun 1, 2019. It is now read-only.

opt-out #43

Closed
steveklabnik opened this issue Jan 26, 2017 · 4 comments
Closed

opt-out #43

steveklabnik opened this issue Jan 26, 2017 · 4 comments

Comments

@steveklabnik
Copy link
Member

Related to #42, an explicit opt out is a good call.

This information is public, as in, it's in the github history for anyone to see, but if someone doesn't want their name on this page for some reason, we should respect that.

I am happy to do this manually for now, but it's gonna need to be automated in some fashion.

@steveklabnik
Copy link
Member Author

Blocked on infrastructure work that's part of #8

@jmatraszek
Copy link
Contributor

jmatraszek commented Feb 1, 2017

I could work on that (cannot commit to work on higher priority issues right now, like fixing support for multiple projects, due to a lack of time).

I think we should do the following:

  1. finally normalize the database and pull the authors out of commits to their own table;
  2. add a new binary (e.g. opt-out) that will mark the author as opted-out (or create a new one marked as opted-out from the start -- if someone wants to opt-out before their project is added to thanks);
  3. fix front-end to respect that.

Going with this approach we would still have the names/emails in the database (just not show them in the front-end), but I think it is acceptable as this data is publicly available in the repos on GitHub. If not, then we should investigate some other solution.

@steveklabnik
Copy link
Member Author

finally normalize the database and pull the authors out of commits to their own table;

💯

add a new binary (e.g. opt-out) that will mark the author as opted-out

💯

fix front-end to respect that.

👍 , luckily this shouldn't need any real front-end work, just modifying queries, which you'll have to do anyway for 1.

I think it is acceptable as this data is publicly available in the repos on GitHub

Yes, this is about ease of getting the information; in my experience, this would be fine. Nobody has straight-up wanted to opt out yet, so I can't consult anyone directly.

jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 1, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 1, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 4, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 5, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 5, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 5, 2017
jmatraszek added a commit to jmatraszek/contributors that referenced this issue Feb 7, 2017
@steveklabnik
Copy link
Member Author

#72 closes this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants