Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thoughts on Patterns #115

Closed
aturon opened this issue Jun 7, 2016 · 2 comments
Closed

Thoughts on Patterns #115

aturon opened this issue Jun 7, 2016 · 2 comments
Labels
Enhancement
Milestone
ch6

Comments

@aturon
Copy link
Member

aturon commented Jun 7, 2016

As it currently stands, the Patterns section feels like it has a quite different style from the rest of the book. It feels much more "Comprehensive Reference" rather than "Friendly guide to the most vital things for a new Rustacean to learn."

We should think carefully about the most important details about patterns that people need to know at this juncture, and consider moving the rest of this content to a later "Advanced patterns" section (which we can work out a good place for).

Alternatively, we had discussed having an explicit marker for "advanced" sections you can skip on a first read, and perhaps we could mark this one that way?
@steveklabnik
Copy link
Member

That's possible. In general, we've been trying to fight the "x and advanced x" ... well, pattern, in chapters. Hrm.

@aturon
Copy link
Member Author

aturon commented Jun 7, 2016

Yeah, it's not ideal. I guess TLDR, my feeling is that we don't want people to feel like they need to get through all of this material on their way to other things -- it's slick, but not essential. So whatever way we can find to make sure readers don't get blocked on it.

@carols10cents carols10cents added this to the ch6 milestone Jun 28, 2016
@carols10cents carols10cents mentioned this issue Jul 1, 2016
Closed
carols10cents added a commit that referenced this issue Jul 2, 2016
@carols10cents
Remove some of the less-commonly-used pattern abilities
cefbd7f 
Connects to #115. Not fixes, because I'm going to give some of these
more motivation before I think we can say we've covered what a new
rustacean *needs* to know.

Connects to #114 because I removed the trailing off last section, but I
do want to give this section a real ending.
carols10cents added a commit that referenced this issue Jul 2, 2016
@carols10cents
Give multiple patterns and ranges more motivation and move them together
418c62e 
I feel like these are useful for the same reasons, are very similar, and
should therefore be discussed in quick succession.

Connects to #115.
carols10cents added a commit that referenced this issue Jul 2, 2016
@carols10cents
Clarify the code examples in the ref/ref mut patterns section
1051a43 
Connects to #115.
carols10cents added a commit that referenced this issue Jul 2, 2016
@carols10cents
Clarify and simplify using _ to ignore parts of bindings
9e292df 
I feel like destructuring tuples and struct fields is less common. I do
think it's worth pointing out that _ doesn't bind, though.

Connects to #115.
carols10cents added a commit that referenced this issue Jul 2, 2016
@carols10cents
Rework the match example to be about coin sorting
7ac400d 
Fixes #115.

Thanks to some brainstorming with @pindell-matt and @selfup at Turing,
we've got what I think is a better analogy of a coin sorting machine!
AbrarNitk pushed a commit to FifthTry/rust-book that referenced this issue Jun 2, 2021
@tatsuya6502
Merge pull request rust-lang#115 from kazunetakahashi/list-19-21
f251571 
Fix: ch19-03 - Add missing caption id for Listing 19-21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
ch6
Development

No branches or pull requests
3 participants
@steveklabnik @carols10cents @aturon