Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting target/doc doesn't first doc regeneration #2379

Closed
hfiguiere opened this issue Feb 11, 2016 · 2 comments
Closed

Deleting target/doc doesn't first doc regeneration #2379

hfiguiere opened this issue Feb 11, 2016 · 2 comments
Labels
C-bug Category: bug Command-doc E-easy Experience: Easy

Comments

@hfiguiere
Copy link

  • Delete target/doc
  • Run cargo doc --no-deps

Observed:
Nothing happens but target/doc is recreated and is empty

Expected:
Doc is all rebuilt.
@hfiguiere
Copy link
Author

This is on rust nightly.

@alexcrichton
Copy link
Member

Ah I think right now the "freshness" to see whether we re-run a target is currently only computed from whether the source change, but should be easy enough to add a check that at least index.html exists!

@alexcrichton alexcrichton added C-bug Category: bug E-easy Experience: Easy Command-doc labels Feb 11, 2016
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Mar 8, 2016
@alexcrichton
Fix rerunning rustdoc when output deleted
2c089cf 
If `crate/index.html` is missing, we need to rerun rustdoc!

Closes rust-lang#2379
@alexcrichton alexcrichton mentioned this issue Mar 8, 2016
Merged
bors added a commit that referenced this issue Mar 10, 2016
@bors
Auto merge of #2448 - alexcrichton:docs-dirty, r=brson
d6e148d 
Fix rerunning rustdoc when output deleted

If `crate/index.html` is missing, we need to rerun rustdoc!

Closes #2379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug Command-doc E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @hfiguiere