Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

same crate-name used for every build.rs crate #2943

Closed
nikomatsakis opened this issue Aug 1, 2016 · 0 comments
Closed

same crate-name used for every build.rs crate #2943

nikomatsakis opened this issue Aug 1, 2016 · 0 comments

Comments

@nikomatsakis
Copy link
Contributor

When cargo builds a build.rs crate, it seems to use the same crate name of build-rs-build and empty disambiguation metadata. This causes problems for rustc's incremental compilation system, since the data for each such crate conflicts. Any kind of unique scheme would be fine (for example, the metadata could identify the crate for which the build.rs is being built).

cc @michaelwoerister
alexcrichton added a commit to alexcrichton/cargo that referenced this issue Aug 2, 2016
@alexcrichton
Always pass -C metadata to the compiler
083ff01 
If it's not otherwise available we just key it off the pkgid which should be
unique enough across compilations. This should help incremental compilation
efforts be "more incremental" across projects.

Closes rust-lang#2943
@alexcrichton alexcrichton mentioned this issue Aug 2, 2016
Merged
bors added a commit that referenced this issue Aug 2, 2016
@bors
Auto merge of #2946 - alexcrichton:build-script-metadata, r=brson
f4a23e7 
Always pass `-C metadata` to the compiler

If it's not otherwise available we just key it off the pkgid which should be
unique enough across compilations. This should help incremental compilation
efforts be "more incremental" across projects.

Closes #2943
@bors bors closed this as completed in #2946 Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikomatsakis