Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo publish doesn't take a --target #4012

Closed
raphaelcohn opened this issue May 9, 2017 · 5 comments
Closed

cargo publish doesn't take a --target #4012

raphaelcohn opened this issue May 9, 2017 · 5 comments

Comments

@raphaelcohn
Copy link

I'm writing a build script for NVML, a persistent memory library for DRAM. NVML only supports x86-64 linux currently, but I'm working on my Mac. I have no problem with building using this approach, as I use a local cross-compile toolchain via --target. However, I can't publish from this machine as cargo publish doesn't take a --target.
@alexcrichton
Copy link
Member

Seems reasonable to me to add! In the meantime you can also just pass --no-verify to avoid compilation verification on publish

@nisargthakkar
Copy link
Contributor

@alexcrichton Is anybody working on this? Can I pick it up? I believe it should not be too difficult of a task. I'm considerably new to Rust, hence, might be way off point. Please share your thoughts

@alexcrichton
Copy link
Member

@nisargthakkar no I believe it's up for grabs, feel free to do so! You may want to take a look at how cargo build works with --target and then you can likely adapt cargo publish to do something similar, likely threading through an option down to verification. Let me know if you need any help!

@nisargthakkar
Copy link
Contributor

@alexcrichton Thanks for all the pointers. I'll try implementing this.

@nisargthakkar nisargthakkar mentioned this issue May 20, 2017
Closed
@nisargthakkar nisargthakkar mentioned this issue Aug 27, 2017
Merged
bors added a commit that referenced this issue Aug 29, 2017
@bors
Auto merge of #4440 - nisargthakkar:publish_target, r=alexcrichton
b524682 
Adding target support to cargo package and cargo publish

Fixing Issue #4012

Same as #4077 but couldn't reopen the PR due to force push after rebasing from master
@carols10cents
Copy link
Member

Looks like this was fixed in #4440, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @carols10cents @raphaelcohn @nisargthakkar