Add a link to the document in the timings report #10492
Conversation
Signed-off-by: hi-rustin <[email protected]>
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thanks! I think I would prefer this not to be so prominent, though. Is there a particular reason you placed it in the header instead of at the bottom of the page? |
I think it might be easier to get the user's attention by putting the document next to the title. Otherwise when they look at the chart they will be confused. Putting it at the end means that the user sees the chart first and then the document. I think we may need to put the document in front. Also I can't find a place at the end where it would look better to add the document link. |
|
@ehuss Could you please look at it again? Thanks! |
Signed-off-by: hi-rustin <[email protected]>
|
Thanks! @bors r+ |
|
📌 Commit 4a12569 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Update cargo 7 commits in dba5baf4345858c591517b24801902a062c399f8..edffc4ada3d77799e5a04eeafd9b2f843d29fc23 2022-04-13 21:58:27 +0000 to 2022-04-19 17:38:29 +0000 - Document cargo-add (rust-lang/cargo#10578) - feat: Support '-F' as an alias for '--features' (rust-lang/cargo#10576) - Completion support for `cargo-add` (rust-lang/cargo#10577) - Add a link to the document in the timings report (rust-lang/cargo#10492) - feat: Import cargo-add into cargo (rust-lang/cargo#10472) - Part 8 of RFC2906 - Keep `InheritableFields` in a `LazyCell` inside `… (rust-lang/cargo#10568) - Part 7 of RFC2906 - Add support for inheriting `exclude` and `include` (rust-lang/cargo#10565)
What does this PR try to resolve?
close #10487
Add a link to the document in the header of timings report.
How should we test and review this PR?
cargo build --timings