Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register .dwp files as debuginfo artifacts so they get uplifted #11384

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Register .dwp files as debuginfo artifacts so they get uplifted
With this change linux split-debuginfo=packed builds will place the final .dwp in the top level target
dir alongside the binary and report it as a file in the json messages. This puts it on equal footing
with .pdb and .dysm files.
Gankra committed Nov 16, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a0a6043bd1947486764d3aeec40e1ee65b26e4db
10 changes: 10 additions & 0 deletions src/cargo/core/compiler/build_context/target_info.rs
Original file line number Diff line number Diff line change
@@ -462,6 +462,16 @@ impl TargetInfo {
// preserved.
should_replace_hyphens: true,
})
} else {
ret.push(FileType {
suffix: ".dwp".to_string(),
prefix: prefix.clone(),
flavor: FileFlavor::DebugInfo,
crate_type: Some(crate_type),
// Currently no known reason to prefer one naming scheme
Copy link
Member

@weihanglo weihanglo Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have a comment with a link to https://dwarfstd.org/doc/DWARF5.pdf or rustc implementation as a reference, like what .pdb and .dSYM do.

// over the other, but the macos approach seems friendlier.
should_replace_hyphens: false,
})
}
}