Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for keeping target directory on clean #11888

Closed
wants to merge 2 commits into from

Conversation

nandesu-utils
Copy link

implements #11887, --keep-directory flag for cargo clean

@rustbot
Copy link
Collaborator

rustbot commented Mar 26, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-documenting-cargo-itself Area: Cargo's documentation Command-clean S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
@rustbot rustbot added the A-cli-help Area: built-in command-line help label Mar 26, 2023
@ehuss
Copy link
Contributor

ehuss commented May 2, 2023

The team discussed this change and have decided that this isn't something we want to add. This is a highly specialized flag, which is something we generally try to avoid. Additionally, PRs are generally only reviewed for accepted features. Before posting a PR for a new feature, usually we want it to be designed and accepted (through an issue or RFC). Will follow up with more discussion on #11887.

@ehuss ehuss closed this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-clean S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants