Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use openssl only on non-Windows platforms #11979

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

weihanglo
Copy link
Member

On Windows, the system-provided Schannel will be used instead.

See

  • Make cargo a workspace rust#109133 (comment)
  • cargo/README.md

    Lines 38 to 49 in 39116cc

    * OpenSSL — Only needed on Unix-like systems and only if the `vendored-openssl` Cargo feature is not used.
    This requires the development headers, which can be obtained from the `libssl-dev` package on Ubuntu or `openssl-devel` with apk or yum or the `openssl` package from Homebrew on macOS.
    If using the `vendored-openssl` Cargo feature, then a static copy of OpenSSL will be built from source instead of using the system OpenSSL.
    This may require additional tools such as `perl` and `make`.
    On macOS, common installation directories from Homebrew, MacPorts, or pkgsrc will be checked. Otherwise it will fall back to `pkg-config`.
    On Windows, the system-provided Schannel will be used instead.
    LibreSSL is also supported.

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2023
@ehuss
Copy link
Contributor

ehuss commented Apr 16, 2023

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 16, 2023

📌 Commit a0bb59c has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
@bors
Copy link
Contributor

bors commented Apr 16, 2023

⌛ Testing commit a0bb59c with merge d0a4cbc...

@bors
Copy link
Contributor

bors commented Apr 16, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing d0a4cbc to master...

@bors bors merged commit d0a4cbc into rust-lang:master Apr 16, 2023
@weihanglo weihanglo deleted the openssl-for-non-windows branch April 16, 2023 18:30
@ehuss ehuss added this to the 1.71.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants