Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version field from publish=false packages #13254

Closed
wants to merge 4 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(ci): cargo-hack --no-dev-deps
One thing to note is that the use of the --all-targets flag (that builds
tests/examples) needed to be removed and the --no-dev-deps flag is needed.
This is because the dev-dependencies use versionless manifests that cannot
be read by the old compiler.

That said, we are not running tests with the old compiler, so I don't see
a problem if the test suite cannot be built on the old compiler.

Co-authored-by: Taiki Endo <[email protected]>
weihanglo and taiki-e committed Jan 25, 2024
commit b0a8a2cdb654807767541f4cccf8c23a14954fc3
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -258,4 +258,4 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: taiki-e/install-action@cargo-hack
- run: cargo hack check --all-targets --rust-version --workspace --no-private
- run: cargo hack check --rust-version --workspace --no-private --no-dev-deps