Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to ECR Public from Docker Hub #14686

Closed
wants to merge 1 commit into from

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

We're hitting this hard.

[internal] load metadata for docker.io/library/httpd:2.4-alpine
ERROR: failed to copy: httpReadSeeker:
failed open: unexpected status code https://registry-1.docker.io/v2/library/httpd/manifests/sha256:66c49302c02430619abb84240a438bcfc083015661009fcaaeaac931450f62cd:
  429 Too Many Requests - Server message: toomanyrequests:
You have reached your pull rate limit.
You may increase the limit by authenticating and upgrading:
https://www.docker.com/increase-rate-limit

And the rate limit seems quite easy to hit.

The rate limits of 100 container image requests per six hours for
anonymous usage, > and 200 container image requests per six hours
for free Docker accounts are now in effect. Image requests exceeding
these limits will be denied until the six hour window elapses.

This PR switches to Amazon ECR public, and alternative image registry,
to unblock us from the rate limit of the official Docker registry.

Both of the two images are verified and uploaded by Docker

See also https://gallery.ecr.aws/

We're hitting this hard.

```
[internal] load metadata for docker.io/library/httpd:2.4-alpine
ERROR: failed to copy: httpReadSeeker:
failed open: unexpected status code https://registry-1.docker.io/v2/library/httpd/manifests/sha256:66c49302c02430619abb84240a438bcfc083015661009fcaaeaac931450f62cd:
  429 Too Many Requests - Server message: toomanyrequests:
You have reached your pull rate limit.
You may increase the limit by authenticating and upgrading:
https://www.docker.com/increase-rate-limit
```

And the rate limit seems quite easy to hit.

> The rate limits of 100 container image requests per six hours for
> anonymous usage, > and 200 container image requests per six hours
> for free Docker accounts are now in effect. Image requests exceeding
> these limits will be denied until the six hour window elapses.

This PR switches to Amazon ECR public, and alternative image registry,
to unblock us from the rate limit of the official Docker registry.

Both of the two images are verified and uploaded by Docker

* https://gallery.ecr.aws/docker/library/alpine
* https://gallery.ecr.aws/docker/library/httpd

See also https://gallery.ecr.aws/
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2024
@sourcefrog
Copy link
Contributor

Just a thought: arguably we should switch to Azure's registry instead, since GitHub workers probably run on Azure? (I'm not totally sure they have public mirrors of this but it seems like they would?)

@sourcefrog
Copy link
Contributor

.. In a bit of searching I can't find public mirrors like this on Azure.

Within GH itself, there is https://github.com/linuxcontainers/alpine/pkgs/container/alpine but I don't think this includes Apache and I'm not sure it should be equally trusted.

@weihanglo
Copy link
Member Author

Seems like we have recovered from the rate limit: #14682 (comment). I am fine with either closing or merging this.

@weihanglo
Copy link
Member Author

.. In a bit of searching I can't find public mirrors like this on Azure.

Neither can I find Azure equivalent. And nothing in https://github.com/orgs/apache/packages nor https://github.com/orgs/alpinelinux/packages 😞.

@ehuss
Copy link
Contributor

ehuss commented Oct 26, 2024

I opened rust-lang/infra-team#176 to figure out what we should do here.

@weihanglo
Copy link
Member Author

Going to close in favor of the discussion rust-lang/infra-team#176.

@weihanglo weihanglo closed this Nov 8, 2024
@weihanglo weihanglo deleted the docker-images branch November 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants