cargo new/init: Conditionalize adding Cargo.lock to gitignore #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cargo new, it depends on --bin option For cargo init, it depends on detected files (--bin option may be used or may be ignored) No tests conver this code so far.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Merged
|
r? @WiSaGaN |
|
@vi looks good to me. But may need a Rust team member to merge? |
|
Thanks @vi! Can you add a test for this as well? |
|
Added 4 tests for cargo init (but not for cargo new). |
bors
added a commit
that referenced
this pull request
Feb 17, 2016
…e, r=alexcrichton For cargo new, it depends on --bin option For cargo init, it depends on detected files (--bin option may be used or may be ignored) No tests conver this code so far.
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cargo new, it depends on --bin option
For cargo init, it depends on detected files
(--bin option may be used or may be ignored)
No tests conver this code so far.