Add a temporary env var to enable hashes in filenames #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For rustbuild we need the hashes to exist for all deps, even if they're path deps, because we care about the actual file names. For example we don't want to install /usr/lib/libstd.so! This adds a "secret" environment variable, `__CARGO_DEFAULT_LIB_METADATA` which re-enables the old behavior of just putting hashes in filenames. Closes rust-lang#3005
|
@alexcrichton: no appropriate reviewer found, use r? to override |
|
r? @brson |
|
@bors r+ |
|
📌 Commit 7e40439 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 19, 2016
Add a temporary env var to enable hashes in filenames For rustbuild we need the hashes to exist for all deps, even if they're path deps, because we care about the actual file names. For example we don't want to install /usr/lib/libstd.so! This adds a "secret" environment variable, `__CARGO_DEFAULT_LIB_METADATA` which re-enables the old behavior of just putting hashes in filenames. Closes #3005
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
alexcrichton
added a commit
to rust-lang-deprecated/rust-packaging
that referenced
this pull request
Aug 22, 2016
alexcrichton
added a commit
to rust-lang-deprecated/rust-packaging
that referenced
this pull request
Aug 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rustbuild we need the hashes to exist for all deps, even if they're path
deps, because we care about the actual file names. For example we don't want to
install /usr/lib/libstd.so!
This adds a "secret" environment variable,
__CARGO_DEFAULT_LIB_METADATAwhichre-enables the old behavior of just putting hashes in filenames.
Closes #3005