Apply --all if workspace is virtual

[rsertelon]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Awesome, thanks! Could you also add some tests for this as well?

[rsertelon]

Will do this evening (GMT+1/2)

[rsertelon]

I've fixed one test that failed because the virtual build was supposed to fail before this PR.

However, I don't really see a way of testing the modification appart from trying to run cargo with a virtual build and verify it returns with a status 0.

Is that actually all that's testable?

[matklad]

However, I don't really see a way of testing the modification appart from trying to run cargo with a virtual build and verify it returns with a status 0.

cargo test would be a convenient command to check that everything is tested: you'll need a workspace with a virtual manifest and two members, foo and bar. You then run cargo test in the virtual package and verify that stdout contains lines test_foo, test_bar. Of course we wouldn't check all other subcommands this way, but the proper fix for this would be to get rid of the duplication somehow.

[rsertelon]

Thanks for the pointer @matklad Won't have time this week-end, but will be back on it next week!

[rsertelon]

I think I've got this. I copied existing tests for virtual workspace, and removed the --all argument and if test fails, it means that the automatic add of --all is broken.

What do you think?

[matklad]

Hm, won't this break a use case when you are in the root of the workspace, but want to exercise a particular package?

I am thinking about something like this:

ws_root/
  Cargo.toml
  foo/
    Cargo.toml
  bar/
    Cargo.toml

$ pwd
~/projects/ws_root/
$ cargo test --pkg foo

If I am right, and the tests are green, this also means that some test is missing :)

[bors]

☔ The latest upstream changes (presumably #4031) made this pull request unmergeable. Please resolve the merge conflicts.

[alexcrichton]

Closing due to inactivity, but please feel free to resubmit with a rebase!