cargo_new: drop the trailing slash for target exclusion in Git #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `target` is a symlink (e.g., to keep build outputs on a separate partition), Git will not match the `/target/` ignore to the symlink since it is not a directory. Drop the trailing slash to support ignoring `target` as a symlink.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
|
📌 Commit f4e0eef has been approved by |
bors
added a commit
that referenced
this pull request
Jan 16, 2018
cargo_new: drop the trailing slash for target exclusion in Git When `target` is a symlink (e.g., to keep build outputs on a separate partition), Git will not match the `/target/` ignore to the symlink since it is not a directory. Drop the trailing slash to support ignoring `target` as a symlink.
|
☀️ Test successful - status-appveyor, status-travis |
1 task
mathstuf
added a commit
to mathstuf/github-gitignore
that referenced
this pull request
Jun 13, 2019
See rust-lang/cargo#4944 for the cargo change.
This was referenced Oct 1, 2019
mathstuf
added a commit
to mathstuf/rust
that referenced
this pull request
Mar 25, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 25, 2020
…r=Mark-Simulacrum gitignore: allow target to be a symlink Following rust-lang/cargo#4944.
This was referenced Mar 26, 2020
mathstuf
added a commit
to mathstuf/github-gitignore
that referenced
this pull request
Sep 28, 2020
See rust-lang/cargo#4944 for the cargo change.
mathstuf
added a commit
to mathstuf/github-gitignore
that referenced
this pull request
Sep 28, 2020
See rust-lang/cargo#4944 for the cargo change.
near-bulldozer bot
pushed a commit
to near/nearcore
that referenced
this pull request
Jan 28, 2022
Allows the `target` build directory to be ignored when symlinked from another partition. With the `target/` spec, git doesn't ignore symlinks because it expects a directory, of which a symlink is not. Prior Art: rust-lang/cargo#4944 As seen in; - https://github.com/rust-lang/rust/blob/6abb6385b2cb7249f67b9b3ce7522527767dd907/.gitignore#L47 - https://github.com/rust-lang/cargo/blob/1c034752de0df744fcd7788fcbca158830b8bf85/.gitignore#L1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
targetis a symlink (e.g., to keep build outputs on a separatepartition), Git will not match the
/target/ignore to the symlinksince it is not a directory. Drop the trailing slash to support ignoring
targetas a symlink.