Add edition info into metadata #5834
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
#5816 will make an edition a property of a target, so it make sense to this in metadata as well |
|
Indeed! @Undin want to switch this to being part of a serialized target? |
Yep! In this case, I'll wait when #5816 will be merged to add edition field into
If we make edition part of target metadata, should we add this info into package data at all? |
|
I think having it in both places is probably best for now, at the package level Cargo may distinguish various features of manifests and so it may be worthwhile at some point! |
|
@Undin ok that PR has now merged! Want to update this when you get a chance? |
|
@alexcrichton yep, I'll update it ASAP |
|
Excellent. Thanks @Undin. |
Since edition feature was introduced, external tools have to support this new feature. But cargo metadata doesn't provide info about package edition. This commit adds edition field to SerializedPackage struct to add the corresponding field into metadata output.
Undin
force-pushed
the
metadata-edition
branch
2 times, most recently
from
0fe707d to
f93eeaa
Compare
|
I've added edition info into target object in metadata |
|
Thanks! Looks like a test may be failing on windows though? |
|
Oops, forgot about slashes |
|
@bors: r+ |
|
📌 Commit 3fdce22 has been approved by |
|
⌛ Testing commit 3fdce22 with merge 140fde355708d122384474cd10f2e814073829ee... |
|
💔 Test failed - status-travis |
|
@bors: retry |
Add edition info into metadata Since edition feature was introduced, external tools have to support this new feature. But cargo metadata doesn't provide info about package edition. This commit adds edition field to `SerializedPackage` struct to add the corresponding field into metadata output.
|
☀️ Test successful - status-appveyor, status-travis |
Since edition feature was introduced, external tools have to support this new feature.
But cargo metadata doesn't provide info about package edition.
This commit adds edition field to
SerializedPackagestruct to add the corresponding field into metadata output.