Fix --build-plan with dev-dependencies
#6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Is it necessary to download everything? Can |
|
Perhaps? I didn't really want to investigate the build plan that much as it's an unstable feature anyway... I'll take a look |
Regressed in rust-lang#6005 it looks like the build plan requires all packages to be downloaded rather than just those coming out of `unit_dependenices`, so let's make sure to download everything! Closes rust-lang#6082
alexcrichton
force-pushed
the
build-plan-dev-deps
branch
from
0fd46e5 to
d8e43e8
Compare
|
@bors r+ |
|
📌 Commit d8e43e8 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed in #6005 it looks like the build plan requires all packages to
be downloaded rather than just those coming out of
unit_dependenices,so let's make sure to download everything!
Closes #6082