-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS all the things #6614
Merged
Merged
HTTPS all the things #6614
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0c3851c
HTTPS all the things
1584bb4
Fix the crates ref to point to https://doc.rust-lang.org/cargo
6d9f3a6
Fix ups per dwijnand's review
ee20f73
Fix unit-test error
a9480ed
Try to get build to fix
46b2b78
Merge branch 'master' into https_all_the_things
7185e98
Changes per ehuss
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ depends on a number of libraries which carry their own copyright notices and | |
license terms. These libraries are normally all linked static into the binary | ||
distributions of Cargo: | ||
|
||
* OpenSSL - http://www.openssl.org/source/license.html | ||
* OpenSSL - https://www.openssl.org/source/license.html | ||
|
||
Copyright (c) 1998-2011 The OpenSSL Project. All rights reserved. | ||
|
||
|
@@ -22,7 +22,7 @@ distributions of Cargo: | |
3. All advertising materials mentioning features or use of this | ||
software must display the following acknowledgment: | ||
"This product includes software developed by the OpenSSL Project | ||
for use in the OpenSSL Toolkit. (http://www.openssl.org/)" | ||
for use in the OpenSSL Toolkit. (https://www.openssl.org/)" | ||
|
||
4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to | ||
endorse or promote products derived from this software without | ||
|
@@ -36,7 +36,7 @@ distributions of Cargo: | |
6. Redistributions of any form whatsoever must retain the following | ||
acknowledgment: | ||
"This product includes software developed by the OpenSSL Project | ||
for use in the OpenSSL Toolkit (http://www.openssl.org/)" | ||
for use in the OpenSSL Toolkit (https://www.openssl.org/)" | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY | ||
EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
|
@@ -1037,7 +1037,7 @@ distributions of Cargo: | |
|
||
---------------------------------------------------------------------- | ||
|
||
* libssh2 - http://www.libssh2.org/license.html | ||
* libssh2 - https://www.libssh2.org/license.html | ||
|
||
Copyright (c) 2004-2007 Sara Golemon <[email protected]> | ||
Copyright (c) 2005,2006 Mikhail Gusarov <[email protected]> | ||
|
@@ -1080,7 +1080,7 @@ distributions of Cargo: | |
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY | ||
OF SUCH DAMAGE. | ||
|
||
* libcurl - http://curl.haxx.se/docs/copyright.html | ||
* libcurl - https://curl.haxx.se/docs/copyright.html | ||
|
||
COPYRIGHT AND PERMISSION NOTICE | ||
|
||
|
@@ -1268,5 +1268,5 @@ distributions of Cargo: | |
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | ||
OTHER DEALINGS IN THE SOFTWARE. | ||
|
||
For more information, please refer to <http://unlicense.org/> | ||
For more information, please refer to <https://unlicense.org/> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1446,8 +1446,8 @@ fn crate_env_vars() { | |
name = "foo" | ||
version = "0.5.1-alpha.1" | ||
description = "This is foo" | ||
homepage = "http://example.com" | ||
repository = "http://example.com/repo.git" | ||
homepage = "https://example.com" | ||
repository = "https://example.com/repo.git" | ||
authors = ["[email protected]"] | ||
"#, | ||
) | ||
|
@@ -1475,8 +1475,8 @@ fn crate_env_vars() { | |
assert_eq!(s, foo::version()); | ||
println!("{}", s); | ||
assert_eq!("foo", PKG_NAME); | ||
assert_eq!("http://example.com", HOMEPAGE); | ||
assert_eq!("http://example.com/repo.git", REPOSITORY); | ||
assert_eq!("https://example.com", HOMEPAGE); | ||
assert_eq!("https://example.com/repo.git", REPOSITORY); | ||
assert_eq!("This is foo", DESCRIPTION); | ||
let s = format!("{}.{}.{}-{}", VERSION_MAJOR, | ||
VERSION_MINOR, VERSION_PATCH, VERSION_PRE); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,11 +126,11 @@ fn http_auth_offered() { | |
.with_status(101) | ||
.with_stderr_contains(&format!( | ||
"\ | ||
[UPDATING] git repository `http://{addr}/foo/bar` | ||
[UPDATING] git repository `https://{addr}/foo/bar` | ||
[ERROR] failed to load source for a dependency on `bar` | ||
|
||
Caused by: | ||
Unable to update http://{addr}/foo/bar | ||
Unable to update https://{addr}/foo/bar | ||
|
||
Caused by: | ||
failed to clone into: [..] | ||
|
@@ -171,7 +171,7 @@ fn https_something_happens() { | |
authors = [] | ||
|
||
[dependencies.bar] | ||
git = "https://127.0.0.1:{}/foo/bar" | ||
git = "http://127.0.0.1:{}/foo/bar" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This test shouldn't be modified, either. |
||
"#, | ||
addr.port() | ||
), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this test should be changed.