Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some tests failing on Windows nightly. #7534

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix some tests failing on Windows nightly. #7534

merged 1 commit into from
Oct 24, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 23, 2019

  • Windows MSVC binaries don't have metadata hash anymore.
  • Properly escape backslashes in config TOML.

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 23, 2019

📌 Commit 3beb139 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2019
@bors
Copy link
Contributor

bors commented Oct 23, 2019

⌛ Testing commit 3beb139 with merge b87532ec719652d6df2f1d2419893a83d61974d1...

@bors
Copy link
Contributor

bors commented Oct 23, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Oct 23, 2019

E: Failed to fetch http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu/pool/main/g/gcc-9/libobjc4_9.1.0-2ubuntu2~16.04_amd64.deb 404 Not Found [IP: 91.189.95.83 80]

I have no idea what that means.

@alexcrichton
Copy link
Member

I think that means that ubuntu is having infrastructure issues (or azure?) and we should probably just wait a few hours

@alexcrichton
Copy link
Member

@bors: retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2019
@bors
Copy link
Contributor

bors commented Oct 24, 2019

⌛ Testing commit 3beb139 with merge dcad4cc...

bors added a commit that referenced this pull request Oct 24, 2019
@bors
Auto merge of #7534 - ehuss:fix-windows-nightly, r=alexcrichton
dcad4cc 
Fix some tests failing on Windows nightly.

- Windows MSVC binaries don't have metadata hash anymore.
- Properly escape backslashes in config TOML.
@bors
Copy link
Contributor

bors commented Oct 24, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing dcad4cc to master...

@bors bors merged commit 3beb139 into rust-lang:master Oct 24, 2019
@ehuss ehuss mentioned this pull request Oct 29, 2019
Merged
bors added a commit to rust-lang/rust that referenced this pull request Oct 30, 2019
@bors
Auto merge of #65941 - ehuss:update-cargo-books, r=alexcrichton
c553e8e 
Update cargo, books.

## cargo

8 commits in 3ba5f27170db10af7a92f2b682e049397197b8fa..5da4b4d47963868d9878480197581ccbbdaece74
2019-10-22 15:05:18 +0000 to 2019-10-28 21:53:41 +0000
- Add --filter-platform to `cargo metadata`. (rust-lang/cargo#7376)
- Fix `cargo fix` not showing colors. (rust-lang/cargo#7550)
- Rephrase --manifest-path section (rust-lang/cargo#7409)
- Add a note to discourage the use of -Zminimal-versions. (rust-lang/cargo#7549)
- Fix profile override warning in a workspace. (rust-lang/cargo#7536)
- Fix some tests failing on Windows nightly. (rust-lang/cargo#7534)
- Show better error message for Windows abnormal termination. (rust-lang/cargo#7535)
- Run `apt update` before `apt install` (rust-lang/cargo#7541)

## reference

8 commits in 5b9d2fc..4b21b64
2019-10-03 22:39:10 +0200 to 2019-10-27 22:33:11 +0100
- Document `const_constructor` feature (rust-lang/reference#677)
- Add `non_exhaustive` to reference. (rust-lang/reference#609)
- Re-add rust-docs component for lintcheck (rust-lang/reference#702)
- group signed and unsigned integers in layout table (rust-lang/reference#700)
- Fix layout table rendering (rust-lang/reference#699)
- Add reference for attributes in function parameters (rust-lang/reference#657)
- Update now that proc macros can expand to macro_rules. (rust-lang/reference#694)
- Fix match in union example. (rust-lang/reference#684)

## book

8 commits in 9bb8b161963fcebc9d9ccd732ba26f42108016d5..28fa3d15b0bc67ea5e79eeff2198e4277fc61baf
2019-10-14 18:42:55 -0500 to 2019-10-29 07:16:09 -0500
- Update Ch19.1 on slice splitting (rust-lang/book#1999)
- fixed inconsistent terminology regarding enums (rust-lang/book#2022)
- Update ch15-03 code to match output. (rust-lang/book#2020)
- Fixes rust-lang/book#2039 (rust-lang/book#2040)
- Update ch15-03-drop.md (rust-lang/book#2049)
- unit type value is also a value (rust-lang/book#2061)
- Minor: remove an extraneous `.` (rust-lang/book#2059)
- Clarifications and consistent use of quotation marks (rust-lang/book#1992)

## rust-by-example

4 commits in 0b111eaae36cc4b4997684be853882a59e2c7ca7..f3197ddf2abab9abdbc029def8164f4a748b0d91
2019-10-14 18:34:25 -0300 to 2019-10-29 10:17:40 -0300
- Fix typos (rust-lang/rust-by-example#1285)
- Improve Cargo / Dependencies section (rust-lang/rust-by-example#1287)
- Improve Cargo / Build Scripts section (rust-lang/rust-by-example#1288)
- Make if_let exercise runnable (rust-lang/rust-by-example#1289)
@ehuss ehuss added this to the 1.40.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Eh2406 Eh2406

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ehuss @rust-highfive @alexcrichton @bors @Eh2406