Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Disable test not forwards compatible to nightly. #7716

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 17, 2019

The --extern flag format changed (see #7699). The changes didn't make it into beta, so just disable this test. This isn't immediately necessary, but will be helpful if we need to make any other changes on the 1.41 branch in the future.

Closes #7714

@rust-highfive
Copy link

r? @Eh2406

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.41.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 17, 2019

📌 Commit 726e47c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2019
@bors
Copy link
Contributor

bors commented Dec 17, 2019

⌛ Testing commit 726e47c with merge 6744533...

bors added a commit that referenced this pull request Dec 17, 2019
[beta] Disable test not forwards compatible to nightly.

The `--extern` flag format changed (see #7699).  The changes didn't make it into beta, so just disable this test.  This isn't immediately necessary, but will be helpful if we need to make any other changes on the 1.41 branch in the future.

Closes #7714
@bors
Copy link
Contributor

bors commented Dec 18, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 6744533 to rust-1.41.0...

@bors bors merged commit 726e47c into rust-lang:rust-1.41.0 Dec 18, 2019
@ehuss ehuss mentioned this pull request Dec 19, 2019
@ehuss ehuss added this to the 1.41.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants