Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suggestion message on bad project name error #9877

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

dswij
Copy link
Member

@dswij dswij commented Sep 6, 2021

closes #9876

Error message suggest adding [bin] to Cargo.toml which should be [[bin]] instead.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2021
@ehuss
Copy link
Contributor

ehuss commented Sep 6, 2021

Thanks!

@bors r+

@ehuss ehuss closed this Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 6, 2021

📌 Commit cb2932e has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2021
@ehuss ehuss reopened this Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 6, 2021

⌛ Testing commit cb2932e with merge 38b4c6ed955c89d5738a63e38834e4f1c5f46464...

@ehuss
Copy link
Contributor

ehuss commented Sep 6, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2021

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Sep 6, 2021

📌 Commit cb2932e has been approved by ehuss

@bors
Copy link
Contributor

bors commented Sep 6, 2021

⌛ Testing commit cb2932e with merge 941b123...

@bors
Copy link
Contributor

bors commented Sep 6, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 941b123 to master...

@bors bors merged commit 941b123 into rust-lang:master Sep 6, 2021
@dswij dswij deleted the fix-init-bin-help branch September 6, 2021 21:18
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
Update cargo

6 commits in 18751dd3f238d94d384a7fe967abfac06cbfe0b9..e515c3277bf0681bfc79a9e763861bfe26bb05db
2021-09-01 14:26:00 +0000 to 2021-09-08 14:32:15 +0000
- Remove log output that may leak tokens (rust-lang/cargo#9873)
- rev = "refs/pull/𑑛/head" (rust-lang/cargo#9859)
- Update suggestion message on bad project name error (rust-lang/cargo#9877)
- clarify what goes into "*-sys" crates (rust-lang/cargo#9871)
- Improve error message when unable to initialize git index repo (rust-lang/cargo#9869)
- Use serde_json to generate cargo_vcs_info.json (rust-lang/cargo#9865)
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 13, 2021
Update cargo

6 commits in 18751dd3f238d94d384a7fe967abfac06cbfe0b9..e515c3277bf0681bfc79a9e763861bfe26bb05db
2021-09-01 14:26:00 +0000 to 2021-09-08 14:32:15 +0000
- Remove log output that may leak tokens (rust-lang/cargo#9873)
- rev = "refs/pull/𑑛/head" (rust-lang/cargo#9859)
- Update suggestion message on bad project name error (rust-lang/cargo#9877)
- clarify what goes into "*-sys" crates (rust-lang/cargo#9871)
- Improve error message when unable to initialize git index repo (rust-lang/cargo#9869)
- Use serde_json to generate cargo_vcs_info.json (rust-lang/cargo#9865)
@ehuss ehuss added this to the 1.57.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when creating a bin project suggests [bin] section in Cargo.toml instead of [[bin]]
5 participants