Better error message when failing on unknown targets #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, actually, I'm not sure what to update the What would you suggest? Just make it more prominent? Or does it not really matter if we have this error message in |
|
The proposed error text looks great, and would have bypassed the ~90 minutes of debugging I had to do working on a new target. |
NobodyXu
approved these changes
Dec 4, 2024
|
This is fantastic, thank you very much! ❤️ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback in #1312.
This assumes that the dev guide will be updated as well, haven't submitted a PR for that yet though.
CC @flba-eb, wdyt?