Allow using Visual Studio target names in find_tool
#1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDenton
force-pushed
the
x86
branch
2 times, most recently
from
7bf8e5b to
f6f6413
Compare
Also fix a bug in vs15plus_vc_paths due to shadowing of the `target` variable.
NobodyXu
requested changes
Dec 29, 2024
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 4, 2025
Bump cc in the compiler Changelog: - Regenerate target info ([rust-lang#1342](rust-lang/cc-rs#1342)) - Allow using Visual Studio target names in `find_tool` ([rust-lang#1335](rust-lang/cc-rs#1335)) - Fix `is_flag_supported` on msvc ([rust-lang#1336](rust-lang/cc-rs#1336))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
find_toolunderstand VS arch names. This is admittedly partly motivated by the fact that rustc internally uses the namex86to refer to eitheri586andi686where the distinction doesn't matter.I also centralized parsing of the user-provided arch name in one place, rather than being repeated in multiple places. This uncovered a bug in
vs15plus_vc_pathswhere we were testing the wrongtargetvariable due to shadowing. I fixed it and renamed the two variablestarget_archandtarget_dirto be clearer.