Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNU AR for illumos #585

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Use GNU AR for illumos #585

merged 1 commit into from
Feb 23, 2021

Conversation

smklein
Copy link
Contributor

@smklein smklein commented Feb 22, 2021

When building some crates that make use of cc-rs in their build scripts, I noticed that cargo build died when running on illumos targets.

Specifically, I saw the following output:

$ cargo build

...

cargo:warning=ar: one of [drqtpmx] must be specified

  exit code: 1

  --- stderr

When supplying the manual environment variable AR=..., I noticed this issue could be avoided. However, the default ar implementation on illumos (in /usr/bin/ar) continued to be incompatible.

This PR updates the default, meaning that cargo build should now "cleanly work" without additional environment variables, by utilizing the "GNU AR" binary bundled with illumos (at /usr/bin/gar) instead of the illlumos-specific one.

Tested this out by compiling ring for illumos - before this patch, it failed, raising the ar issue. After this patch, it builds successfully with no errors.

@smklein
Copy link
Contributor Author

smklein commented Feb 22, 2021

@jclulow , FYI

@jclulow
Copy link
Contributor

jclulow commented Feb 22, 2021

Thanks for the heads up -- I'll take a look!

@alexcrichton alexcrichton merged commit 3f0aa40 into rust-lang:master Feb 23, 2021
@alexcrichton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants